feat: TPU *Create / *get / *create_with_script / *delete Samples by Thoughtseize1 · Pull Request #12690 · GoogleCloudPlatform/python-docs-samples

Thoughtseize1 · 2024-10-10T12:24:32Z

Description

Created new Samples for TPU. Create, Get, Delete operations.
Also added Sample for creating TPU with Startup Script
Doc page -> here

Region tag	Sample
`tpu_vm_create`	`/tpu/create_tpu.py`
`tpu_vm_get`	`/tpu/get_tpu.py`
`tpu_vm_delete`	`/tpu/delete_tpu.py`
`tpu_vm_create_startup_script`	`/tpu/create_tpu_with_script.py`

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.9 (see Test Environment Setup)
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
Please merge this PR for me once it is approved

snippet-bot · 2024-10-10T13:50:43Z

Here is the summary of changes.

You are about to add 4 region tags.

tpu/create_tpu.py:36, tag tpu_vm_create
tpu/create_tpu_with_script.py:26, tag tpu_vm_create_startup_script
tpu/delete_tpu.py:25, tag tpu_vm_delete
tpu/get_tpu.py:28, tag tpu_vm_get

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

m-strzelczyk

Looks good!

I forgot to tell you all, TPUs are a separate product from Compute (politics....). So please move the whole tpu folder, a level higher to the repository root.

You'll need to update CODEOWNERS file and .github/blunderbuss.yml file. Just copy the setting of compute for tpu.

Thoughtseize1 · 2024-10-11T14:16:30Z

Looks good!

I forgot to tell you all, TPUs are a separate product from Compute (politics....). So please move the whole tpu folder, a level higher to the repository root.

You'll need to update CODEOWNERS file and .github/blunderbuss.yml file. Just copy the setting of compute for tpu.

I've moved the TPU folder to the root of the repository. I updated the CODEOWNERS file and .github/blunderbuss.yml. Could you please review and confirm if everything is correct? @m-strzelczyk

tpu/test_tpu.py

m-strzelczyk · 2024-10-15T15:05:31Z

tpu/create_tpu_with_script.py

+    # [START tpu_vm_create_startup_script]
+    # This startup script updates numpy to the latest version and logs the output to a file.
+    metadata = {
+        "startup-script": """#!/bin/bash
+    echo "Hello World" > /var/log/hello.log
+    sudo pip3 install --upgrade numpy >> /var/log/hello.log 2>&1
+    """
+    }
+    node = tpu_v2.Node()
+    # Adding metadata with startup script to the TPU node.
+    node.metadata = metadata
+    # Enabling external IPs for internet access from the TPU node.
+    node.network_config = tpu_v2.NetworkConfig(enable_external_ips=True)
+
+    # [END tpu_vm_create_startup_script]


Maybe make this region tag span the whole node creation code. The gcloud example in docs is a full gcloud command, so we should have a full creation script as well IMO.

I changed it to provide users with a full example of creating TPU with the startup script 👍

…gleCloudPlatform#12690) * Added create /get / delete / create_startup_script TPU Samples with tests and NOX configuration * Update CODEOWNERS and blunderbuss.yml

Added create/get/delete TPU Samples with tests and NOX configuration

084df0f

product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Oct 10, 2024

Thoughtseize1 added 2 commits October 10, 2024 14:33

Fix lint checks

d5f9423

Fix lint

667ce71

Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 10, 2024

snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 10, 2024

Update comments

bce6848

Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 10, 2024

snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 10, 2024

Thoughtseize1 marked this pull request as ready for review October 10, 2024 14:27

Thoughtseize1 requested review from a team as code owners October 10, 2024 14:27

blunderbuss-gcf bot assigned Sita04 Oct 10, 2024

Thoughtseize1 requested a review from m-strzelczyk October 10, 2024 14:32

Thoughtseize1 assigned m-strzelczyk and unassigned Sita04 Oct 10, 2024

m-strzelczyk requested changes Oct 11, 2024

View reviewed changes

Thoughtseize1 added 2 commits October 11, 2024 16:07

Moved TPU Samples to separate folder

d11ddc2

Update CODEOWNERS and blunderbuss.yml

5e15094

Thoughtseize1 requested review from a team as code owners October 11, 2024 14:08

Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 11, 2024

snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 11, 2024

Thoughtseize1 requested a review from m-strzelczyk October 11, 2024 14:17

Thoughtseize1 added 2 commits October 15, 2024 16:12

Delete metadata from create_tpu.py Sample. Added docstrings.

b29e7c1

Added new TPU Sample. Updated tests.

078df9c

Thoughtseize1 added snippet-bot:force-run Force snippet-bot runs its logic api: tpu Issues related to the Cloud TPU API. labels Oct 15, 2024

snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 15, 2024

Thoughtseize1 changed the title ~~feat: TPU Create/get/delete Samples~~ feat: TPU *Create / *get / *create_with_script / *delete Samples Oct 15, 2024

m-strzelczyk approved these changes Oct 15, 2024

View reviewed changes

tpu/test_tpu.py Outdated Show resolved Hide resolved

Thoughtseize1 added 2 commits October 15, 2024 17:04

Fix typo

abea018

Fix typo

61c3723

m-strzelczyk reviewed Oct 15, 2024

View reviewed changes

Thoughtseize1 added 2 commits October 15, 2024 17:08

Changed to full example of tpu_vm_create_startup_script Sample

1876b1c

Changed tests to different zone.

7786b07

Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2024

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2024

Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2024

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2024

Thoughtseize1 added 2 commits October 16, 2024 12:56

Updated tests

855aa6f

Try "us-south1-a"

7ad6f4d

Thoughtseize1 merged commit 1207521 into main Oct 16, 2024

Thoughtseize1 deleted the create-get-tpu branch October 16, 2024 11:34

This was referenced Oct 18, 2024

feat(tpu): add create/delete/get samples GoogleCloudPlatform/java-docs-samples#9585

Merged

feat(tpu): add tpu vm create topology and tpu vm create startup script samples GoogleCloudPlatform/java-docs-samples#9590

Closed

This was referenced Oct 29, 2024

feat(tpu): add tpu vm list sample. GoogleCloudPlatform/java-docs-samples#9606

Merged

feat(tpu): add tpu vm create startup script sample. GoogleCloudPlatform/java-docs-samples#9612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: TPU Create / get / create_with_script / delete Samples#12690

feat: TPU Create / get / create_with_script / delete Samples#12690
Thoughtseize1 merged 14 commits intomainfrom
create-get-tpu

Thoughtseize1 commented Oct 10, 2024 •

edited

Loading

Uh oh!

snippet-bot bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

m-strzelczyk left a comment

Uh oh!

Thoughtseize1 commented Oct 11, 2024

Uh oh!

Uh oh!

m-strzelczyk Oct 15, 2024

Uh oh!

Thoughtseize1 Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Thoughtseize1 commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

snippet-bot bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-strzelczyk left a comment

Choose a reason for hiding this comment

Uh oh!

Thoughtseize1 commented Oct 11, 2024

Uh oh!

Uh oh!

m-strzelczyk Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

Thoughtseize1 Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Thoughtseize1 commented Oct 10, 2024 •

edited

Loading

snippet-bot bot commented Oct 10, 2024 •

edited

Loading